Received: from eggs.gnu.org ([2001:4830:134:3::10]:42900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ruM-0005XC-TV for qemu-devel@nongnu.org; Fri, 18 Dec 2015 05:05:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9ruJ-0006hp-He for qemu-devel@nongnu.org; Fri, 18 Dec 2015 05:05:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ruJ-0006h1-C9 for qemu-devel@nongnu.org; Fri, 18 Dec 2015 05:05:03 -0500 From: Markus Armbruster References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-22-git-send-email-armbru@redhat.com> <56732EED.9020702@redhat.com> Date: Fri, 18 Dec 2015 11:04:59 +0100 In-Reply-To: <56732EED.9020702@redhat.com> (Eric Blake's message of "Thu, 17 Dec 2015 14:53:49 -0700") Message-ID: <878u4shy2c.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 21/23] error: Clean up errors with embedded newlines (again) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Pavel Fedin , Laszlo Ersek , qemu-devel@nongnu.org Eric Blake writes: > On 12/17/2015 09:50 AM, Markus Armbruster wrote: >> The arguments of error_report() should yield a short error string >> without newlines. >> >> A few places try to print additional help after the error message by >> embedding newlines in the error string. That's nice, but let's do it >> the right way. Commit 474c213 cleaned up some, but they keep coming >> back. Offenders tracked down with the Coccinelle semantic patch from >> commit 312fd5f. > > Not sure if you'll have any stragglers from 1/23 here, after fixing 16/23. Just one: qemu-nbd.c:604:28:"Invalid number of argument.\n" "Try `%s --help' for more information." >> >> Cc: Laszlo Ersek >> Cc: Pavel Fedin >> Signed-off-by: Markus Armbruster >> Reviewed-by: Laszlo Ersek >> --- >> hw/i386/pc.c | 4 ++-- >> kvm-all.c | 6 +++--- >> 2 files changed, 5 insertions(+), 5 deletions(-) >> > > Reviewed-by: Eric Blake Thanks!