Received: from eggs.gnu.org ([2001:4830:134:3::10]:45553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUusX-0003tM-SO for qemu-devel@nongnu.org; Fri, 19 Sep 2014 05:53:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUusP-0001f6-JX for qemu-devel@nongnu.org; Fri, 19 Sep 2014 05:53:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUusP-0001eU-Bt for qemu-devel@nongnu.org; Fri, 19 Sep 2014 05:53:17 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8J9rBNT031492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 19 Sep 2014 05:53:11 -0400 From: Markus Armbruster References: <1411063146-24058-1-git-send-email-jsnow@redhat.com> Date: Fri, 19 Sep 2014 11:53:09 +0200 In-Reply-To: <1411063146-24058-1-git-send-email-jsnow@redhat.com> (John Snow's message of "Thu, 18 Sep 2014 13:59:03 -0400") Message-ID: <878ulgq6m2.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC v2 0/3] Q35/AHCI -cdrom/-hda desugaring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-devel@nongnu.org John Snow writes: > This is an extremely rough/quick sketch of > a -cdrom/-hda desugaring fix for Q35/AHCI. > > Before I spent any time on it, I wanted feedback > from Markus or anyone else who had concerns about > how this problem would get fixed. > > This is, then, rough approach #2. > > Highlights: > (1) Add a board property (instead of a HBA property, sigh) > that defines how we should map (index, (bus,unit)). Imperfect, but it'll do for now. The place in the boards that sets it should point to the HBA in a comment. > (2) Modify drive_new to accept the MachineClass instead of > the default interface type. This does not affect how > default drives get added, because any over-rides to > the "default type" get handled in options, so while > it appears we have removed the type of default drives, > we have not. > > (3) Create helpers for AHCI to assist the Q35 board in > populating the AHCI device with the IDE drives. > > (4) Create a helper to whine at us for oversights and > help bug reporters give us more meaningful information. General approach looks good to me; I can see only coding bugs, not design flaws.