Received: from eggs.gnu.org ([2001:4830:134:3::10]:59193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUWUB-0007K2-4S for qemu-devel@nongnu.org; Thu, 18 Sep 2014 03:50:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUWU4-0001fv-0e for qemu-devel@nongnu.org; Thu, 18 Sep 2014 03:50:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUWU3-0001fa-N4 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 03:50:31 -0400 From: Markus Armbruster References: <1410953466-26543-1-git-send-email-kwolf@redhat.com> <20140917114917.GA22298@irqsave.net> <20140917122820.GA4737@noname.redhat.com> Date: Thu, 18 Sep 2014 09:50:20 +0200 In-Reply-To: <20140917122820.GA4737@noname.redhat.com> (Kevin Wolf's message of "Wed, 17 Sep 2014 14:28:20 +0200") Message-ID: <878ulhiczn.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] block: Validate node-name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: =?utf-8?Q?Beno=C3=AEt?= Canet , qemu-devel@nongnu.org, stefanha@redhat.com Kevin Wolf writes: > Am 17.09.2014 um 13:49 hat Beno=C3=AEt Canet geschrieben: >>=20 >>=20 >> > +int qemu_opts_id_wellformed(const char *id) >>=20 >> This return 0 and 1 as a bool. >> Could we make the function return bool in the same series ? > > I considered the change (as you probably saw, the new block.c function > returns a bool), but then thought it wasn't important enough. > > In any case, that would be something for a separate patch. If you think > it's important, I can send one. > >> I wonder what are the possible interferences between !strchr("-._", id[i= ]) >> and Jeff's node name auto naming series. > > We might need to update the code then, but it would actually be a good > reason why auto-naming wouldn't hurt if it uses characters that you > can't use manually. I'm afraid this is something we should ponder in a wider context, not just BDS names. Ties to other users of QemuOpts IDs, such as qdev, and to how QOM lets users refer to objects.