Return-Path: From: ebiederm@xmission.com (Eric W. Biederman) To: Andy Lutomirski Cc: Eric Dumazet , Sven Joachim , Greg Kroah-Hartman , "linux-kernel\@vger.kernel.org" , stable@vger.kernel.org, Ding Tianhong , Eric Dumazet , "David S. Miller" , Karel Srot References: <20130402221104.163133110@linuxfoundation.org> <20130402221116.307254752@linuxfoundation.org> <87vc833kpf.fsf@turtle.gmx.de> <87k3ojnosa.fsf@xmission.com> <1365034777.13853.46.camel@edumazet-glaptop> <87li8zjf48.fsf@xmission.com> Date: Wed, 03 Apr 2013 19:24:34 -0700 In-Reply-To: (Andy Lutomirski's message of "Wed, 3 Apr 2013 17:53:02 -0700") Message-ID: <878v4zghi5.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL Sender: linux-kernel-owner@vger.kernel.org List-ID: Andy Lutomirski writes: > On Wed, Apr 3, 2013 at 5:47 PM, Eric W. Biederman wrote: >> >> No. The patch is still bogus. >> >> If the problem is that we are not coallescing messages in stream_recvmsg >> we need a different fix. >> >> Probably something like: >> >> if (check_creds) { >> /* Never glue messages from different writers */ >> if ((UNIXCB(skb).pid != siocb->scm->pid) || >> (UNIXCB(skb).cred != siocb->scm->cred)) >> break; >> - } else { >> + } else if (test_bit(SOCK_PASSCRED, &sock->flags)) { >> /* Copy credentials */ >> scm_set_cred(siocb->scm, UNIXCB(skb).pid, UNIXCB(skb).cred); >> check_creds = 1; >> } > > I'm confused. Isn't this making the problem worse, not better? For udev that is a don't care. For the case where we are coallescing messages this ensures we always collaesce messages if we don't care about the credentials. Which turns out to be a fix for a long standing pessimization, that no on has bother to complain about. > With my patches, the cost should go way down and it could be made > unconditional, but that's still probably not a good -stable change. Reducing the cost and the complexity as far as we can is good, but we really want small steps as we optimize the case of sending credentials. Eric