From: OGAWA Hirofumi Subject: Re: [PATCH take 2][RFC] fat: Save FAT root directory timestamps to volume label Date: Tue, 28 Jul 2009 00:10:48 +0900 Message-ID: <878wia6u13.fsf@devron.myhome.or.jp> References: <1248274841-3586-1-git-send-email-ext-jorg.2.schummer@nokia.com> <1248428635-26073-1-git-send-email-ext-jorg.2.schummer@nokia.com> <87fxclmhxy.fsf@devron.myhome.or.jp> <1248691635.4618.43.camel@jorg-desktop> <87ljmas5ym.fsf@devron.myhome.or.jp> <1248706563.4618.95.camel@jorg-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-kernel\@vger.kernel.org" , "linux-fsdevel\@vger.kernel.org" To: =?iso-8859-1?Q?J=F6rg?= Schummer Return-path: Received: from mail.parknet.ad.jp ([210.171.162.6]:35476 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbZG0PKt (ORCPT ); Mon, 27 Jul 2009 11:10:49 -0400 In-Reply-To: <1248706563.4618.95.camel@jorg-desktop> (=?iso-8859-1?Q?=22J?= =?iso-8859-1?Q?=F6rg?= Schummer"'s message of "Mon, 27 Jul 2009 17:56:03 +0300") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: J=F6rg Schummer writes: > Hello again, > > just in case you (or perhaps somebody else) have a minute to assist m= e.. > > On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote: > >> BTW, the patch has several bugs. fat_get_label_entry() doesn't check >> IS_FREE(), is it right? > > Not 100% sure if it's needed in a consistent fs, but I guess it > shouldn't do any harm, so I added it. If label was removed, what happen? I was assumed utility does label_de->name[0] =3D DELETED_FLAG; >> spin_lock() usage is wrong. > >>From the code, I'm not totally sure then what inode_hash_lock is > supposed to protect in fat_write_inode. Probably it should prevent th= at > the dir entry of an inode is being moved around to another i_pos whil= e > it's being changed? > > But in the pre-patch version of fat_write_inode, shouldn't then > mark_buffer_dirty(bh) be called when the lock is still held? I meant, read/write of storage might sleep, so it shouldn't hold spin_lock when does it. If you set debug CONFIG_* of locking, I guess it will warn. Thanks. --=20 OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html