From: Markus Armbruster Subject: Re: [PATCH][PVFB][LINUX] Fix possible sleep while holding spinlock Date: Fri, 15 Dec 2006 19:35:37 +0100 Message-ID: <878xh9t3ba.fsf@pike.pond.sub.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: (Keir Fraser's message of "Fri, 15 Dec 2006 18:06:13 +0000") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Atsushi SAKAI , xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Keir Fraser writes: > On 15/12/06 16:38, "Markus Armbruster" wrote: > >> This patch fixes the locking, but leaves open a race between >> xenfb_update_screen() and do_no_page(). See the source code for a >> detailed explanation of how it works, and where it fails. > > That's a bit of a shame. Is there any way we could use do_file_page() and > have a populate hook (which gets to install the PTE itself)? Or are there > lots of assumptions about VMAs that would take this path, assert > VM_NONLINEAR, etc? > > -- Keir My colleages and I suspect we need a deep think about the problem. But right now we can't spare the time for that.