From: "cron2 (Code Review)" Date: Thu, 12 Mar 2026 08:03:14 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <8795b74a563fdc2be5c6e807b37825d58922d730-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="zm6z/T1Uzs8="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: dns: Change arguments to setenv_dns_option to avoid sign-compare warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --zm6z/T1Uzs8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.o= penvpn.net/c/openvpn/+/1558?usp=3Demail ) Change subject: dns: Change arguments to setenv_dns_option to avoid sign-co= mpare warning ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/openvpn/dns.c: http://gerrit.openvpn.net/c/openvpn/+/1558/comment/fccde101_7d7bf6c3?usp=3D= email : PS2, Line 487: if (!j) technically this is fine, but it takes me as a reader few more seconds to u= nderstand what this check does - I would prefer `if (j =3D=3D 0)` here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1558?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibfcc350c772227cfc0f2244fa2b1625dcb7e6fb5 Gerrit-Change-Number: 1558 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 12 Mar 2026 08:03:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --zm6z/T1Uzs8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos.

Patch set 2:Code-Review -1=

V= iew Change

1 comment:

  • File src/openvpn/dns.c:

    • Patch Set #2,= Line 487: if (!j)<= /code>

      technically this is fine, but it takes me as a reader few more s= econds to understand what this check does - I would prefer `if (j =3D=3D 0)= ` here.

To view, visit change 1558. To unsubscribe, o= r for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibfcc350c772227cfc0f2244fa2b= 1625dcb7e6fb5
Gerrit-Change-Number: 1558
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Thu, 12 Mar 2026 08:03:14= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --zm6z/T1Uzs8=--