Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oarlS-0002QQ-0L for mharc-qemu-riscv@gnu.org; Wed, 21 Sep 2022 00:55:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oarlQ-0002OG-F1 for qemu-riscv@nongnu.org; Wed, 21 Sep 2022 00:55:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oarlO-0006cT-8J for qemu-riscv@nongnu.org; Wed, 21 Sep 2022 00:55:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663736109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d0ewimBIuzA4pcXzNcXQGF6URaG5NO+EI7K2JWsTSM0=; b=S41yArKW1b6yDJD2YPp1jNb++qi6diFwoGaQ2qy8jc6mal7L1Zb8ezPDVkHbMY7xIrpae4 tF2pBgjPTm0dCvL8k3x+P70Z1n39tMBE2whCTCQ7EZpxM3N94YfO404amPL//lozRX5uFU dKUftHj5iO9g4mmRqm174BdG9awx3H4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-JDdO1-4NNtms04LwtNgKXw-1; Wed, 21 Sep 2022 00:55:07 -0400 X-MC-Unique: JDdO1-4NNtms04LwtNgKXw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67BF02999B47; Wed, 21 Sep 2022 04:55:05 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EFABE2024CC8; Wed, 21 Sep 2022 04:55:03 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C2B8221E6900; Wed, 21 Sep 2022 06:55:02 +0200 (CEST) From: Markus Armbruster To: Bernhard Beschow Cc: Alistair Francis , Bin Meng , Palmer Dabbelt , "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Eric Auger , David Gibson , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Christian Borntraeger , =?utf-8?Q?C=C3=A9dric?= Le Goater , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?utf-8?Q?Herv=C3=A9?= Poussineau , "open list:New World" , Cornelia Huck , Helge Deller , Stefano Stabellini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> <87edw6xoog.fsf@pond.sub.org> <0BBD7391-7B2D-44E7-9396-D1747784B9DA@gmail.com> Date: Wed, 21 Sep 2022 06:55:02 +0200 In-Reply-To: <0BBD7391-7B2D-44E7-9396-D1747784B9DA@gmail.com> (Bernhard Beschow's message of "Tue, 20 Sep 2022 23:23:52 +0000") Message-ID: <87a66tgwd5.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 04:55:12 -0000 Bernhard Beschow writes: > Am 20. September 2022 11:36:47 UTC schrieb Markus Armbruster : >>Alistair Francis writes: >> >>> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote: >>>> >>>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to >>>> inherit from TYPE_MACHINE. This is an inconsistency which can cause >>>> undefined behavior such as memory corruption. >>>> >>>> Change SiFiveEState to inherit from MachineState since it is registered >>>> as a machine. >>>> >>>> Signed-off-by: Bernhard Beschow >>> >>> Reviewed-by: Alistair Francis >> >>To the SiFive maintainers: since this is a bug fix, let's merge it right >>away. > > I could repost this particular patch with the three new tags (incl. Fixes) if desired. Can't hurt, and could help the maintainers.