From: Michael Ellerman Date: Wed, 22 Jul 2020 00:52:32 +0000 Subject: Re: [PATCH v2 1/3] powerpc: inline doorbell sending functions Message-Id: <87a6zss75b.fsf@mpe.ellerman.id.au> List-Id: References: <20200630115034.137050-1-npiggin@gmail.com> <20200630115034.137050-2-npiggin@gmail.com> In-Reply-To: <20200630115034.137050-2-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org Cc: Nicholas Piggin , kvm-ppc@vger.kernel.org, Paul Mackerras , =?utf-8?Q?C=C3=A9dric?= Le Goater , Anton Blanchard , David Gibson Nicholas Piggin writes: > These are only called in one place for a given platform, so inline them > for performance. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/include/asm/dbell.h | 63 ++++++++++++++++++++++++++++++-- > arch/powerpc/kernel/dbell.c | 55 ---------------------------- > 2 files changed, 60 insertions(+), 58 deletions(-) > > diff --git a/arch/powerpc/include/asm/dbell.h b/arch/powerpc/include/asm/dbell.h > index 4ce6808deed3..f19d2282e3f8 100644 > --- a/arch/powerpc/include/asm/dbell.h > +++ b/arch/powerpc/include/asm/dbell.h > @@ -13,6 +13,7 @@ > > #include > #include > +#include > > #define PPC_DBELL_MSG_BRDCAST (0x04000000) > #define PPC_DBELL_TYPE(x) (((x) & 0xf) << (63-36)) This somehow breaks ppc40x_defconfig and others: In file included from /home/michael/linux/arch/powerpc/include/asm/kvm_ppc.h:24, from /home/michael/linux/arch/powerpc/include/asm/dbell.h:16, from /home/michael/linux/arch/powerpc/kernel/asm-offsets.c:38: /home/michael/linux/arch/powerpc/include/asm/kvm_booke.h: In function ‘kvmppc_get_fault_dar’: /home/michael/linux/arch/powerpc/include/asm/kvm_booke.h:94:19: error: ‘struct kvm_vcpu_arch’ has no member named ‘fault_dear’ 94 | return vcpu->arch.fault_dear; | ^ make[2]: *** [/home/michael/linux/scripts/Makefile.build:114: arch/powerpc/kernel/asm-offsets.s] Error 1 make[1]: *** [/home/michael/linux/Makefile:1175: prepare0] Error 2 make: *** [Makefile:185: __sub-make] Error 2 cheers