From: Markus Armbruster <armbru@redhat.com>
References: <20180815133747.25032-1-peterx@redhat.com>
Date: Tue, 28 Aug 2018 21:05:15 +0200
In-Reply-To: <20180815133747.25032-1-peterx@redhat.com> (Peter Xu's message of
	"Wed, 15 Aug 2018 21:37:34 +0800")
Message-ID: <87a7p6l3bo.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v6 00/13] monitor: enable OOB by default
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Dr . David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>

Peter Xu <peterx@redhat.com> writes:

> Hi, Markus, Marc-Andre,
>
> I didn't follow up the latest discussions on the response queue or
> monitor changes.  For now this series still makes sense to me, so I'm
> just rebasing the series to master and repost (with some additional
> changes/patches to address Markus's concerns). Please let me know if
> you have made any conclusion that I'm not aware of, or if this work
> needs any further rebasing.
>
> v6 (previous version of the series might be incorrect; from this
> version, I continued to use the old version counts):
> - collect r-bs
> - use Markus's version of build_params() [Markus]
> - use \' instead of \" in Python codes [Markus]
> - in qapi_event_send_*() still pass in &error_abort instead of NULL
>   [Markus]
> - remove COMMAND_DROPPED from document too
> - add missing pieces for test-qmp-cmds [Markus]
> - add one patch to remove as much different code path for oob as
>   possible [Markus]
>
> TODO:
> - flow control test is still missing; I still didn't consider it much,
>   also we possibly need to touch up monitor_puts() to use limited
>   sized buffer to complete the flow control of QMP channel
>
> Please review.  Thanks,

PATCH 01-03 queued.  Thanks!