Received: from eggs.gnu.org ([2001:4830:134:3::10]:45724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfcLZ-0001yz-O7 for qemu-devel@nongnu.org; Sun, 19 Feb 2017 20:00:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfcLZ-00046N-1t for qemu-devel@nongnu.org; Sun, 19 Feb 2017 20:00:57 -0500 From: Markus Armbruster References: <1483194856-14079-1-git-send-email-hpoussin@reactos.org> <8737gsl7o7.fsf@dusky.pond.sub.org> <4b140d8b-0745-6d7f-101f-25c3ca5f28c2@redhat.com> Date: Mon, 20 Feb 2017 02:00:46 +0100 In-Reply-To: (=?utf-8?Q?=22Herv=C3=A9?= Poussineau"'s message of "Sat, 18 Feb 2017 18:58:10 +0100") Message-ID: <87a89hvfpd.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] vl: disable default cdrom when using explicitely scsi-hd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Herv=C3=A9?= Poussineau Cc: Paolo Bonzini , qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org, Laurent Vivier , John Snow , qemu-block@nongnu.org Herv=C3=A9 Poussineau writes: > Hi, > > Le 09/01/2017 =C3=A0 14:48, Paolo Bonzini a =C3=A9crit : >> >> >> On 09/01/2017 13:49, Markus Armbruster wrote: >>> Herv=C3=A9 Poussineau writes: >>> >>>> 'ide-hd', 'ide-cd' and 'scsi-cd' devices already disable default cdrom. >>>> Make it the same for 'scsi-hd'. >>>> >>>> That way, we can add/replace the device on lun=3D2 without using -node= faults. >>> >>> Yes, but it might upset existing usage that relies on the default >>> CD-ROM. In my opinion, making your needs explicit is better than >>> relying on defaults, but that doesn't mean we can change the defaults >>> unthinkingly. Definitely not qemu-trivial. >>> >>> Opinions on the change? >> >> The original rationale for the change was "ide-hd has to suppress the >> default CD-ROM, or else you can't put one on secondary master without >> -nodefaults" but the same applies for scsi-hd vs. lun=3D1. >> >> So I'm not sure, but I lean towards accepting the patch. >> >> Paolo > > Paolo, Markus, so what is the conclusion? > Accepting the patch, or refusing it? Suggest to repost with the commit message updated to mention the backwards incompatibility, and why you think it's okay. cc: John Snow , cc: qemu-block@nongnu.org