From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
References: <87k2qp8yxv.fsf@mail.parknet.co.jp>
	<87fv1d8ywp.fsf@mail.parknet.co.jp>
	<87bnc18yvw.fsf_-_@mail.parknet.co.jp>
	<1444837495.4467.29.camel@redhat.com>
	<87y4f56lzu.fsf@mail.parknet.co.jp>
	<1444895333.24283.7.camel@redhat.com>
Date: Thu, 15 Oct 2015 17:24:01 +0900
In-Reply-To: <1444895333.24283.7.camel@redhat.com> (Gerd Hoffmann's message of
	"Thu, 15 Oct 2015 09:48:53 +0200")
Message-ID: <87a8rk7d5q.fsf@mail.parknet.co.jp>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars
	on -curses mode
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

>> vga_to_curses[] is filled by curses_setup(). So if no -curses option, I
>> think it should have no change to behavior. (BTW, there is no common
>> section like kernel in qemu build, right?  i.e. no need initializer to
>> global value.)
>
> Ok, curses and gtk can't be active at the same time.  But for curses and
> vnc it is possible (qemu -curses -vnc :$display), and you probably get a
> dissorted vga text mode over vnc then.
>
> I think the mapping should happen in the curses code, when curses
> updates the screen.  curses_update() function is probably the best place
> for it.

OK. It would be possible though, but parsing at curses_update() is
slower. It is why, I did at that. Well, I'll see.

> Also you don't need a init function, you can simply init the array with
> c99 initializers:
>
> chtype vga_to_curses[256] = {
>     [0x04] = ACS_DIAMOND,
>     [ ... ]
> };

This is not possible, because ACS_* is not constant (initialized by
reading from termcap or such).

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>