Received: from eggs.gnu.org ([2001:4830:134:3::10]:49907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqMYg-0005hr-D5 for qemu-devel@nongnu.org; Tue, 10 Dec 2013 07:37:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqMYa-0005aJ-7c for qemu-devel@nongnu.org; Tue, 10 Dec 2013 07:37:02 -0500 From: Markus Armbruster References: <1386675153-1147-1-git-send-email-imammedo@redhat.com> Date: Tue, 10 Dec 2013 13:12:14 +0100 In-Reply-To: <1386675153-1147-1-git-send-email-imammedo@redhat.com> (Igor Mammedov's message of "Tue, 10 Dec 2013 12:32:33 +0100") Message-ID: <87a9g8lxb5.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] fix build regression in qxl-render.c caused by ac86048 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-trivial@nongnu.org, sw@weilnetz.de, mjt@tls.msk.ru, qemu-devel@nongnu.org, kraxel@redhat.com Igor Mammedov writes: > fixes regression caused by commit > ac86048 trace: Remove trace.h from console.h (less dependencies) > which makes build fail with: > > hw/display/qxl-render.c: In function =E2=80=98qxl_blit=E2=80=99: > hw/display/qxl-render.c:34:5: error: implicit declaration of function =E2= =80=98trace_qxl_render_blit=E2=80=99 [-Werror=3Dimplicit-function-declarati= on] > trace_qxl_render_blit(qxl->guest_primary.qxl_stride, > > Signed-off-by: Igor Mammedov > --- > hw/display/qxl-render.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c > index d34b0c4..84f1367 100644 > --- a/hw/display/qxl-render.c > +++ b/hw/display/qxl-render.c > @@ -20,6 +20,7 @@ > */ >=20=20 > #include "qxl.h" > +#include "trace.h" >=20=20 > static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect) > { Fix is pending already: https://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg01314.html