From: OGAWA Hirofumi Subject: Re: [PATCH v2 2/5] fat: add fat_fallocate operation Date: Sun, 01 Dec 2013 21:32:30 +0900 Message-ID: <87a9gkeopt.fsf@devron.myhome.or.jp> References: <1384688277-2901-1-git-send-email-linkinjeon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Amit Sahrawat To: Namjae Jeon Return-path: In-Reply-To: <1384688277-2901-1-git-send-email-linkinjeon@gmail.com> (Namjae Jeon's message of "Sun, 17 Nov 2013 20:37:57 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Namjae Jeon writes: > + err = fat_get_cluster(inode, FAT_ENT_EOF, > + &fclus, &dclus); > + if (err < 0) { > + fat_msg(sb, KERN_ERR, > + "fat_fallocate(): fat_get_cluster() error"); > + goto error; > + } > + free_bytes = ((fclus + 1) << sbi->cluster_bits) - > + inode->i_size; What is wrong if we just used ->mmu_private here, instead of fclus? -- OGAWA Hirofumi