From: Markus Armbruster <armbru@redhat.com>
References: <20130820182051.7766.29027.stgit@bling.home>
Date: Wed, 21 Aug 2013 11:31:39 +0200
In-Reply-To: <20130820182051.7766.29027.stgit@bling.home> (Alex Williamson's
	message of "Tue, 20 Aug 2013 12:21:57 -0600")
Message-ID: <87a9kbs83o.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] q35: Add PCIe switch to example q35
	configuration
To: Alex Williamson <alex.williamson@redhat.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com

Alex Williamson <alex.williamson@redhat.com> writes:

> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>  docs/q35-chipset.cfg |   23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/docs/q35-chipset.cfg b/docs/q35-chipset.cfg
> index 1b6efc0..e4ddb7d 100644
> --- a/docs/q35-chipset.cfg
> +++ b/docs/q35-chipset.cfg
> @@ -91,6 +91,29 @@
>    port = "4"
>    chassis = "4"
>  
> +##
> +# Example PCIe switch with two downstream ports
> +#
> +#[device "pcie-switch-upstream-port-1"]
> +#  driver = "x3130-upstream"
> +#  bus = "ich9-pcie-port-4"
> +#  addr = "00.0"
> +#
> +#[device "pcie-switch-downstream-port-1-1"]
> +#  driver = "xio3130-downstream"
> +#  multifunction = "on"
> +#  bus = "pcie-switch-upstream-port-1"
> +#  addr = "00.0"
> +#  port = "1"
> +#  chassis = "5"
> +#
> +#[device "pcie-switch-downstream-port-1-2"]
> +#  driver = "xio3130-downstream"
> +#  multifunction = "on"
> +#  bus = "pcie-switch-upstream-port-1"
> +#  addr = "00.1"
> +#  port = "1"
> +#  chassis = "6"
>  
>  [device "ich9-ehci-1"]
>    driver = "ich9-usb-ehci1"

Yes, please!

I decommented the three device definitions, and the result looks fine in
info qtree.

A brief hint at why you would want a PCIe switch in the comment would
perhaps be nice.