From: Eric Anholt Subject: Re: [RFC PATCH] agp/intel: Fix cache control for Sandybridge Date: Fri, 28 May 2010 11:09:21 -0700 Message-ID: <87aarjc2zy.fsf@pollan.anholt.net> References: <1274928910-6648-1-git-send-email-zhenyuw@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1600857776==" Return-path: In-Reply-To: <1274928910-6648-1-git-send-email-zhenyuw@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zhenyu Wang Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1600857776== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 27 May 2010 10:55:10 +0800, Zhenyu Wang w= rote: > Sandybridge GTT has new cache control bits in PTE, which controls > graphics page cache in LLC or LLC/MLC. This one trys to setup a > new gtt driver for Gen6, and using new type mask function for that. > And this sets cache control to always LLC only by default on Gen6. >=20 > As this gtt memory cache control bits are internal to intel hw, > so I don't add new flags in agp_backend.h but add them only in > intel_gtt.c. So drm/i915 stuff needs to know these new flags too. >=20 > Signed-off-by: Zhenyu Wang Please put shared definitions in a header file instead of having two .c files define them. intel-agp.h maybe? You might need to move the IS_*, but they should probably be bitfields in device info like they are in i915 now, and then the macros could go away. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkwABtEACgkQHUdvYGzw6vfKLACfUQ/462j+Kp8bfKfR61CIvsPW BZ4AnRKnfjccbC6P9ZLj7qLVWTE43BKs =ziCn -----END PGP SIGNATURE----- --=-=-=-- --===============1600857776== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1600857776==--