Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ml0ZY-0000oF-E9 for qemu-devel@nongnu.org; Tue, 08 Sep 2009 09:17:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ml0ZU-0000mA-3G for qemu-devel@nongnu.org; Tue, 08 Sep 2009 09:17:24 -0400 Received: from [199.232.76.173] (port=40958 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ml0ZT-0000m4-NY for qemu-devel@nongnu.org; Tue, 08 Sep 2009 09:17:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39904) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ml0ZT-0000BW-3k for qemu-devel@nongnu.org; Tue, 08 Sep 2009 09:17:19 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n88DHHkA000524 for ; Tue, 8 Sep 2009 09:17:17 -0400 Received: from pike.pond.sub.org (vpn-10-108.str.redhat.com [10.32.10.108]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n88DHGRg018033 for ; Tue, 8 Sep 2009 09:17:17 -0400 From: Markus Armbruster Date: Sat, 05 Sep 2009 00:13:04 +0200 Message-ID: <87ab1a5pfz.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] [PATCH] qdev: Fix i6300 upcast List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Use DO_UPCAST() instead of container_of() to go from PCIDevice to I6300State. This ensures that PCIDevice is the first member of struct I6300State. Signed-off-by: Markus Armbruster --- hw/wdt_i6300esb.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c index 6927d43..fc038c8 100644 --- a/hw/wdt_i6300esb.c +++ b/hw/wdt_i6300esb.c @@ -198,7 +198,7 @@ static void i6300esb_timer_expired(void *vp) static void i6300esb_config_write(PCIDevice *dev, uint32_t addr, uint32_t data, int len) { - I6300State *d = container_of(dev, I6300State, dev); + I6300State *d = DO_UPCAST(I6300State, dev, dev); int old; i6300esb_debug("addr = %x, data = %x, len = %d\n", addr, data, len); @@ -226,7 +226,7 @@ static void i6300esb_config_write(PCIDevice *dev, uint32_t addr, static uint32_t i6300esb_config_read(PCIDevice *dev, uint32_t addr, int len) { - I6300State *d = container_of(dev, I6300State, dev); + I6300State *d = DO_UPCAST(I6300State, dev, dev); uint32_t data; i6300esb_debug ("addr = %x, len = %d\n", addr, len); @@ -360,7 +360,7 @@ static void i6300esb_map(PCIDevice *dev, int region_num, i6300esb_mem_writew, i6300esb_mem_writel, }; - I6300State *d = container_of(dev, I6300State, dev); + I6300State *d = DO_UPCAST(I6300State, dev, dev); int io_mem; i6300esb_debug("addr = %x, size = %x, type = %d\n", addr, size, type); @@ -415,7 +415,7 @@ static int i6300esb_load(QEMUFile *f, void *vp, int version) static int i6300esb_init(PCIDevice *dev) { - I6300State *d = container_of(dev, I6300State, dev); + I6300State *d = DO_UPCAST(I6300State, dev, dev); uint8_t *pci_conf; d->reboot_enabled = 1; -- 1.6.2.5