From: Eric Anholt Subject: Re: [PATCH v2 2/2] drm/vc4: Disable V3D interactions if the v3d component didn't probe. Date: Wed, 03 Apr 2019 12:15:29 -0700 Message-ID: <87bm1moq7i.fsf@anholt.net> References: <20190401183559.3823-1-eric@anholt.net> <20190401183559.3823-2-eric@anholt.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Paul Kocialkowski , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Maxime Ripard List-Id: dri-devel@lists.freedesktop.org --=-=-= Content-Type: text/plain Paul Kocialkowski writes: > Hi, > > On Mon, 2019-04-01 at 11:35 -0700, Eric Anholt wrote: >> One might want to use the VC4 display stack without using Mesa. >> Similar to the debugfs fixes for not having all of the possible >> display bits enabled, make sure you can't oops in vc4 if v3d isn't >> enabled. > > Just thought about this: perhaps we should be returning -ENODEV instead > of -EINVAL when !vc4->v3d, just so that the error is a bit more > explicit to userspace? I like it. Doing that while applying the series. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlylBlEACgkQtdYpNtH8 nugVaBAAiL1YcEpP77T4qlkmL2FNDFcSRt6dsyldUZPGcj3aqltXF4N6rjT/+xp6 l9md04QkPb15W1CNDOqtEMTBr9oq3U1m6ULITCP84Je1pzbZ5Etf5dfXeHMBnKJ5 NSX6i8u5uuqopEZS/RucilsOrxQvithN6HVtrvqU8SR/dY/Uti6VB306WGEa7RTZ QwdOUjcAL5uLMUS6AhrLr/csuNtUDnAKqdabeOQFdpCffZFudA97ik4LhFG8RaTk dB1sHqwNkasPwjI2cxm2yolLgnoI6qEP9HkJ30lcinG16F2ViW8adtGkfEDISHL7 5iXXJqmBo7qDWViqTynF77KAoxrOz9LnesxrvHmH1vBaBSmgXobPpj6rYMftJaIq CPh4di5/aiN8C3rLO+M7R3NZ0n7XYT3x+4y2PbiGwwLgsyQZTvqscaRNiZZk/Z7V WAVLmyQO2PkprLGMxjlrXh1MKOYW1roc9oJb3pyNgs+dGLC8upvyHrxqNGYbcqsz xqhBoaNz+rTIxIohvxRXIUoUbylFCdZq0RvBAl8oFyyJfI4LnldLHi9980hLpBiS e/XvtPEfW+XyS8j7MO8mpIRTivqj3yIqcrd6isHo6WzZCRnFQdEbPS+sxu0uyMiR zEWWc+h2jCWOVHY6rDHXo8n821HxtYy6esT4NTdNhdv2rK8aiV4= =WQsh -----END PGP SIGNATURE----- --=-=-=--