Return-Path: From: OGAWA Hirofumi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fat: Relax checks for sector size and media type References: <20180902131932.11558-1-pali.rohar@gmail.com> Date: Mon, 03 Sep 2018 16:17:26 +0900 In-Reply-To: <20180902131932.11558-1-pali.rohar@gmail.com> ("Pali =?iso-8859-1?Q?Roh=E1r=22's?= message of "Sun, 2 Sep 2018 15:19:32 +0200") Message-ID: <87bm9ft5h5.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: Pali Roh�r writes: > Windows fastfat.sys driver accepts also media types 0x00 and 0x01 and > sector sizes 128 and 256 bytes. Linux mkfs.fat can format disk also to > larger FAT sector sizes then 4096 bytes, therefore relax also upper limit > restriction. > - if (!is_power_of_2(bpb->fat_sector_size) > - || (bpb->fat_sector_size < 512) > - || (bpb->fat_sector_size > 4096)) { > + if (!is_power_of_2(bpb->fat_sector_size)) { Just relaxing validation doesn't work. The block layer doesn't support smaller than 512, and lager than PAGE_SIZE. (And in specification, fat doesn't support lager than 4096.) > static inline int fat_valid_media(u8 media) > { > - return 0xf8 <= media || media == 0xf0; > + return 0xf8 <= media || media == 0xf0 || media == 0x00 || media == 0x01; > } > #endif /* !_LINUX_MSDOS_FS_H */ This is ok though, this would be for ancient floppy media. Thanks. -- OGAWA Hirofumi