Received: from eggs.gnu.org ([2001:4830:134:3::10]:35204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0rLD-0007Sa-Uq for qemu-devel@nongnu.org; Mon, 23 Nov 2015 08:39:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0rLD-0002JM-3T for qemu-devel@nongnu.org; Mon, 23 Nov 2015 08:39:35 -0500 From: Markus Armbruster References: <1448042670-17433-1-git-send-email-berrange@redhat.com> <1448042670-17433-2-git-send-email-berrange@redhat.com> <564F9A15.8050109@redhat.com> <20151123123347.GF18085@redhat.com> Date: Mon, 23 Nov 2015 14:39:27 +0100 In-Reply-To: <20151123123347.GF18085@redhat.com> (Daniel P. Berrange's message of "Mon, 23 Nov 2015 12:33:47 +0000") Message-ID: <87bnakzvg0.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH WIP 01/30] crypto: add QCryptoSecret object class for password/key handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org "Daniel P. Berrange" writes: > On Fri, Nov 20, 2015 at 03:09:25PM -0700, Eric Blake wrote: >> On 11/20/2015 11:04 AM, Daniel P. Berrange wrote: >> > + >> > +static const char *base64_valid_chars = >> > + "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/="; >> > + >> > +static int >> > +qcrypto_secret_validate_base64(const uint8_t *input, >> > + size_t inputlen, >> > + Error **errp) >> >> Don't we already have base64 utility methods available? > > We normally use glib, g_base64_encode/decode. Unfortunately the > decode method doesn't provide any usefull error reporting facility. > It just silently skips any characters that are outside the valid > set. So the only way I could get any kind of sensible error report > was to do this validation myself against the set of permitted base64 > characters. Yes. Same problem elsewhere, e.g. ringbuf-write. qapi-schema.json: # - base64: data must be base64 encoded text. Its binary # decoding gets written. # Bug: invalid base64 is currently not rejected. # Whitespace *is* invalid. This suggests that we shouldn't bury this in crypto/, but instead add it to util/. A replacement for g_base64_decode() could be easier to use than a checker function to use in addition to g_base64_decode(), [...]