Received: from eggs.gnu.org ([2001:4830:134:3::10]:45531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztu2U-00023f-Gm for qemu-devel@nongnu.org; Wed, 04 Nov 2015 04:07:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ztu2Q-0005Qg-Df for qemu-devel@nongnu.org; Wed, 04 Nov 2015 04:07:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztu2Q-0005Qc-7x for qemu-devel@nongnu.org; Wed, 04 Nov 2015 04:07:26 -0500 From: Markus Armbruster References: <1446618049-13596-1-git-send-email-eblake@redhat.com> <1446618049-13596-7-git-send-email-eblake@redhat.com> Date: Wed, 04 Nov 2015 10:07:23 +0100 In-Reply-To: <1446618049-13596-7-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 3 Nov 2015 23:20:28 -0700") Message-ID: <87bnbat9o4.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v9 06/27] qapi: Test failure in middle of array parse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth Eric Blake writes: > Our generated list visitors have the same problem as has been > mentioned elsewhere (see commit 2f52e20): they allocate data > even on failure. An upcoming patch will correct things to > provide saner guarantees, but first we need to expose the > behavior in the testsuite to ensure we aren't introducing any > memory usage bugs. > > Signed-off-by: Eric Blake This commit documents the problem and adds test coverage. Commit 2f52e20 only documented. Do we have test coverage? Patch looks good.