Received: from eggs.gnu.org ([2001:4830:134:3::10]:51660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZydw-0005dr-OI for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:59:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZydw-0002MW-4p for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:59:48 -0400 From: Markus Armbruster References: <1440623592-13999-1-git-send-email-jsnow@redhat.com> <55F0602C.20207@redhat.com> <55F065B2.30509@redhat.com> <55F066B2.50907@redhat.com> Date: Thu, 10 Sep 2015 11:59:40 +0200 In-Reply-To: <55F066B2.50907@redhat.com> (John Snow's message of "Wed, 9 Sep 2015 13:04:50 -0400") Message-ID: <87bnda7fxv.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/4] ide: simple ATAPI tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, qemu-block@nongnu.org, zuban32s@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini John Snow writes: > On 09/09/2015 01:00 PM, Paolo Bonzini wrote: >> >> >> On 09/09/2015 18:37, John Snow wrote: >>> Ping -- apologies. :) >>> >>> I'll take a simple ACK before I merge it into my tree. >> >> I don't think you need one. :) >> >> Paolo >> > > I guess technically not, but I like when somebody at least takes a peek > before I just brazenly send pullreqs. > > I haven't achieved the level of ATA COWBOY yet. I like the prudent attitude. For tests, however, you can lower the bar a bit. Anyway, it looks sane to me.