Received: from eggs.gnu.org ([2001:4830:134:3::10]:33333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZNwd-0000sr-LB for qemu-devel@nongnu.org; Tue, 08 Sep 2015 14:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZNwa-0006sA-Vo for qemu-devel@nongnu.org; Tue, 08 Sep 2015 14:48:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZNwa-0006rf-R3 for qemu-devel@nongnu.org; Tue, 08 Sep 2015 14:48:36 -0400 From: Markus Armbruster References: <1441621003-2434-1-git-send-email-armbru@redhat.com> <1441621003-2434-31-git-send-email-armbru@redhat.com> <55EF08B4.7090201@redhat.com> Date: Tue, 08 Sep 2015 20:48:33 +0200 In-Reply-To: <55EF08B4.7090201@redhat.com> (Eric Blake's message of "Tue, 8 Sep 2015 10:11:32 -0600") Message-ID: <87bndcg326.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC v5 30/32] qapi: New QMP command query-qmp-schema for QMP introspection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Eric Blake writes: > On 09/07/2015 04:16 AM, Markus Armbruster wrote: >> qapi/introspect.json defines the introspection schema. It's designed >> for QMP introspection, but should do for similar uses, such as QGA. >> >> The introspection schema does not reflect all the rules and >> restrictions that apply to QAPI schemata. A valid QAPI schema has an >> introspection value conforming to the introspection schema, but the >> converse is not true. >> > >> Right now qmp_query_schema() sends the string literal computed by > > Should this be spelled qmp_query_qmp_schema()? [1] Yes. >> qmp-introspect.py. To compute sub-schema at run time, we'd have to >> duplicate parts of qapi-introspect.py in C. Unattractive. > > >> Signed-off-by: Markus Armbruster >> --- > > Changes I noticed from v4: > Simple unions work now. > Documentation improvements. > Rename to query-qmp-schema (except perhaps where I marked [1], but I'm > not too fussed with either spelling). > Use of self._member for internal fields. > > Reviewed-by: Eric Blake Thanks!