From: Raja R Harinath Subject: Re: [PATCH] cifs: implement drop_inode superblock op Date: Wed, 26 May 2010 07:46:58 +0530 Message-ID: <87bpc3iezp.fsf@hariville.hurrynot.org> References: <1274815488-29173-1-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-cifs-client@lists.samba.org To: linux-fsdevel@vger.kernel.org Return-path: Received: from lo.gmane.org ([80.91.229.12]:54864 "EHLO lo.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932591Ab0EZJuJ (ORCPT ); Wed, 26 May 2010 05:50:09 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OHDFU-0003Ip-EA for linux-fsdevel@vger.kernel.org; Wed, 26 May 2010 11:50:04 +0200 Received: from 117.192.141.135 ([117.192.141.135]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 26 May 2010 11:50:04 +0200 Received: from harinath by 117.192.141.135 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 26 May 2010 11:50:04 +0200 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, Jeff Layton writes: [snip] > static const struct super_operations cifs_super_ops = { > .put_super = cifs_put_super, > .statfs = cifs_statfs, > .alloc_inode = cifs_alloc_inode, > .destroy_inode = cifs_destroy_inode, > -/* .drop_inode = generic_delete_inode, > - .delete_inode = cifs_delete_inode, */ /* Do not need above two > + .drop_inode = cifs_drop_inode, > +/* .delete_inode = cifs_delete_inode, */ /* Do not need above two > functions unless later we add lazy close of inodes or unless the > kernel forgets to call us with the same number of releases (closes) > as opens */ I think the comment needs to be updated, at least to decrement the "two functions". - Hari