From: "flichtenheld (Code Review)" Date: Mon, 8 Jul 2024 11:14:41 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <87cb49a39e9c4dfe7f6a0f1dd4c2986d0fe26d32-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="0PdKrN9kE5Y="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Allow trailing \r and \n in control channel message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --0PdKrN9kE5Y= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/672?usp=3Demail ) Change subject: Allow trailing \r and \n in control channel message ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/f61c55e2_9b297160 : PS1, Line 309: /* Remove \r and \n at the end of the buffer= to avoid Why can't you use buf_chomp? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e Gerrit-Change-Number: 672 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Mon, 08 Jul 2024 11:14:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --0PdKrN9kE5Y= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 1:Code-Review -1=

Vi= ew Change

1 comment:

  • File src/openvpn/forward.c:

    <= ul style=3D"list-style: none; padding: 0;">
  • Patch Set #1, Line 309:= /* Rem= ove \r and \n at the end of the buffer to avoid

    Why can't you use buf_chomp?<= /p>

To view, visit change 672. To unsubscribe, or for help= writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f72= 0cf50dc1fbe3e
Gerrit-Change-Number: 672
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Mon, 08 Jul 2024 11:14:41= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--0PdKrN9kE5Y=--