From: Fabiano Rosas Date: Thu, 28 Apr 2022 16:37:38 +0000 Subject: Re: [PATCH] KVM: PPC: Book3S HV: Initialize AMOR in nested entry Message-Id: <87czh1qi3x.fsf@linux.ibm.com> List-Id: References: <20220425142151.1495142-1-farosas@linux.ibm.com> <1651118922.7qh15cf4pc.astroid@bobo.none> In-Reply-To: <1651118922.7qh15cf4pc.astroid@bobo.none> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org Cc: kvm-ppc@vger.kernel.org Nicholas Piggin writes: > Excerpts from Fabiano Rosas's message of April 26, 2022 12:21 am: >> The hypervisor always sets AMOR to ~0, but let's ensure we're not >> passing stale values around. >> > > Reviewed-by: Nicholas Piggin > > Looks like our L0 doesn't do anything with hvregs.amor ? It doesn't. And if the HV ever starts clearing bits from AMOR, then we would need to change any kernel code that writes and reads from AMR ( such as the KUAP) to take into consideration that we might read a different value from what we wrote.