From: Peter Korsgaard Date: Sun, 26 May 2019 11:16:34 +0200 Subject: [Buildroot] [PATCH v2,1/1] package/qt5enginio: needs ssl In-Reply-To: <3c08a2ee-d0d1-8ca2-ccf6-e411f0802344@mind.be> (Arnout Vandecappelle's message of "Fri, 10 May 2019 17:07:53 +0200") References: <20190505124731.18275-1-fontaine.fabrice@gmail.com> <3c08a2ee-d0d1-8ca2-ccf6-e411f0802344@mind.be> Message-ID: <87d0k5mv7x.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Arnout" == Arnout Vandecappelle writes: > Hi Fabrice, > On 05/05/2019 14:47, Fabrice Fontaine wrote: >> qt5enginio needs Qt5 with ssl support, a dependency could be added on >> BR2_PACKAGE_QT5BASE_OPENSSL but this proposal was rejected in the first >> iteration of this patch >> >> Qt5 has ssl support through libressl on Qt 5.6 or openssl in latest Qt >> however we can't select libressl without adding a circular dependency as >> some packages (such as sqlcipher) force openssl through >> BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL >> >> So, as suggested by Arnout: >> - add a hidden BR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSL option that >> selects BR2_PACKAGE_OPENSSL if qt5enginio is selected >> - remove select on BR2_PACKAGE_QT5BASE to avoid a circular dependency >> and because it's not needed as BR2_PACKAGE_QT5 already selects >> BR2_PACKAGE_QT5BASE >> - add dependencies of BR2_PACKAGE_LIBRESSL if Qt 5.6 is selected (but >> don't select libressl to avoid a circular dependency) >> >> Fixes: >> - http://autobuild.buildroot.org/results/60678cab68ec9aa17184b8417b64b3b79adf428a >> >> Signed-off-by: Fabrice Fontaine >> --- >> Changes v1 -> v2 (after review of Thomas Petazzoni and Arnout >> Vandecappelle): >> - Remove dependency on BR2_PACKAGE_QT5BASE_OPENSSL >> >> package/qt5/qt5enginio/Config.in | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/package/qt5/qt5enginio/Config.in b/package/qt5/qt5enginio/Config.in >> index 102058e7c5..94bf295396 100644 >> --- a/package/qt5/qt5enginio/Config.in >> +++ b/package/qt5/qt5enginio/Config.in >> @@ -1,7 +1,15 @@ >> +# This is a hack to avoid circular dependencies when selecting OPENSSL >> +config BR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSL >> + bool >> + default y if BR2_PACKAGE_QT5ENGINIO >> + select BR2_PACKAGE_OPENSSL > Unfortunately, this still doesn't work for Qt5.6. > However, there is not much we can do there. Selecting libressl is not possible, > so we have to depend on it, so we can't select libopenssl or we'd get a circular > dependency. > So, I've gone back to your original patch but changed the depends into a > select, and I added a comment that for Qt5.6 you need to select libressl: > comment "qt5enginio needs libressl for Qt5.6" > depends on BR2_PACKAGE_QT5_VERSION_5_6 > depends on !BR2_PACKAGE_LIBRESSL > This would still lead to autobuild failures for Qt5.6, of course, because it is > still possible to select libopenssl instead of libressl. But we don't test Qt5.6 > in the autobuilders, so that's fine. > With that, I've applied to master. Many thanks for keeping on trying to fix > this properly. Committed to 2019.02.x, thanks. -- Bye, Peter Korsgaard