Received: from eggs.gnu.org ([209.51.188.92]:47549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2cfR-0005CI-Tw for qemu-devel@nongnu.org; Sat, 09 Mar 2019 09:09:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2cfR-0003jh-7Y for qemu-devel@nongnu.org; Sat, 09 Mar 2019 09:09:37 -0500 From: Markus Armbruster References: <20190308013222.12524-1-philmd@redhat.com> <20190308013222.12524-2-philmd@redhat.com> Date: Sat, 09 Mar 2019 15:09:27 +0100 In-Reply-To: <20190308013222.12524-2-philmd@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Fri, 8 Mar 2019 02:32:05 +0100") Message-ID: <87d0n05eco.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 01/18] hw/arm/virt: Remove null-check in virt_build_smbios() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Laszlo Ersek , Gerd Hoffmann , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Peter Maydell , Thomas Huth , Eduardo Habkost , Mark Cave-Ayland , "Dr. David Alan Gilbert" , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Igor Mammedov , Paolo Bonzini , David Gibson , Artyom Tarasenko , Richard Henderson Philippe Mathieu-Daud=C3=A9 writes: > Since commit 578f3c7b0835 ("arm: add fw_cfg to "virt" board", > 2014-12-22), the machvirt_init() unconditionally creates the > fw_cfg object. Later, commit c30e15658b1b ("smbios: implement > smbios support for mach-virt", 2015-09-07) added a superfluous > null-check on it. > Remove this superfluous check. > > Fixes: c30e15658b1b I'd use 'Fixes:' only for bug fixes. This is a cleanup > Reviewed-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Markus Armbruster