Received: from eggs.gnu.org ([2001:4830:134:3::10]:51423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRccT-0005wh-9Z for qemu-devel@nongnu.org; Tue, 27 Nov 2018 07:37:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRccP-0007Qf-8D for qemu-devel@nongnu.org; Tue, 27 Nov 2018 07:37:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27681) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRccP-0007P6-2b for qemu-devel@nongnu.org; Tue, 27 Nov 2018 07:37:33 -0500 From: Markus Armbruster References: <1543312923-3074-1-git-send-email-liq3ea@gmail.com> <1543312923-3074-2-git-send-email-liq3ea@gmail.com> Date: Tue, 27 Nov 2018 13:37:24 +0100 In-Reply-To: <1543312923-3074-2-git-send-email-liq3ea@gmail.com> (Li Qiang's message of "Tue, 27 Nov 2018 02:02:02 -0800") Message-ID: <87d0qqr917.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 1/2] hw: pc: use TYPE_XXX instead of constant strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Qiang Cc: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org Li Qiang writes: > TYPE_VMMOUSE is defined in vmmouse.c currently, move it > to pc.h in order to use it in pc.c. > > Signed-off-by: Li Qiang Reviewed-by: Markus Armbruster