Received: from eggs.gnu.org ([2001:4830:134:3::10]:55834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiigt-0007j0-Bq for qemu-devel@nongnu.org; Mon, 05 Feb 2018 10:28:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiign-0006fl-Pn for qemu-devel@nongnu.org; Mon, 05 Feb 2018 10:28:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57772) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eiign-0006c0-KS for qemu-devel@nongnu.org; Mon, 05 Feb 2018 10:28:13 -0500 From: Markus Armbruster References: <20180202130336.24719-1-armbru@redhat.com> <20180202130336.24719-3-armbru@redhat.com> Date: Mon, 05 Feb 2018 16:28:06 +0100 In-Reply-To: (Marc-Andre Lureau's message of "Mon, 5 Feb 2018 14:44:43 +0100") Message-ID: <87d11jjw1l.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 02/21] qapi: Generate up-to-date copyright notice List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc-Andre Lureau Cc: marcandre , qemu-devel , mdroth@linux.vnet.ibm.com Marc-Andre Lureau writes: > Hi > > On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wro= te: >> Each generator carries a copyright notice for the generator itself, >> and another one for the files it generates. Only the former have been >> updated along the way, the latter have not, and are all out of date. >> >> Fix by copying the generator's copyright notice to the generated files >> instead. > > That makes sense, but we loose the Author lines in the generated > files. Not a big deal I guess, but worth to point out, no? We do. They've become just as outdated as the copyright notices. Giving them the same treatment doesn't seem to be worth the trouble. I'm happy to explain this in the commit message. >> >> Signed-off-by: Markus Armbruster > > Other than that, > Reviewed-by: Marc-Andr=C3=A9 Lureau Thanks!