From: felipe.balbi@linux.intel.com (Felipe Balbi) Date: Wed, 22 Jun 2016 11:15:44 +0300 Subject: [PATCH] usb: renesas_usbhs: make usbhs_write32() static In-Reply-To: References: <1466531574-3096-1-git-send-email-ben.dooks@codethink.co.uk> Message-ID: <87d1n9ljv3.fsf@linux.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Mathieu Malaterre writes: > On Tue, Jun 21, 2016 at 7:52 PM, Ben Dooks wrote: >> The usbhs_write32 function is not used outside of the rcar3.c >> file, so fix the following sparse warning by making it static: >> >> drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static? >> >> Signed-off-by: Ben Dooks >> --- >> Cc: Yoshihiro Shimoda >> Cc: Greg Kroah-Hartman >> Cc: linux-usb at vger.kernel.org >> Cc: linux-renesas-soc at vger.kernel.org >> Cc: linux-arm-kernel at lists.infradead.org >> --- >> drivers/usb/renesas_usbhs/rcar3.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c >> index 38b01f2..1d70add 100644 >> --- a/drivers/usb/renesas_usbhs/rcar3.c >> +++ b/drivers/usb/renesas_usbhs/rcar3.c >> @@ -23,7 +23,7 @@ >> #define UGCTRL2_RESERVED_3 0x00000001 /* bit[3:0] should be B'0001 */ >> #define UGCTRL2_USB0SEL_OTG 0x00000030 >> >> -void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) >> +static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data) >> { >> iowrite32(data, priv->base + reg); >> } >> -- >> 2.8.1 > > static inline ? why? compiler can make that choice -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 818 bytes Desc: not available URL: