Received: from eggs.gnu.org ([2001:4830:134:3::10]:40775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axyMD-0005pi-Fh for qemu-devel@nongnu.org; Wed, 04 May 2016 11:05:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axyM0-0003TO-Qs for qemu-devel@nongnu.org; Wed, 04 May 2016 11:04:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axyM0-0003Qj-L7 for qemu-devel@nongnu.org; Wed, 04 May 2016 11:04:44 -0400 From: Markus Armbruster References: <1461879932-9020-13-git-send-email-eblake@redhat.com> <1462370743-1541-1-git-send-email-eblake@redhat.com> Date: Wed, 04 May 2016 17:04:31 +0200 In-Reply-To: <1462370743-1541-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Wed, 4 May 2016 08:05:43 -0600") Message-ID: <87d1p1lv9c.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] fixup! qapi: Document visitor interfaces, add assertions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth Eric Blake writes: > [no change to commit message] > > Signed-off-by: Eric Blake > --- > include/qapi/visitor.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h > index 0bb2fe1..2211637 100644 > --- a/include/qapi/visitor.h > +++ b/include/qapi/visitor.h > @@ -174,7 +174,7 @@ > * v = ...obtain visitor... > * visit_start_struct(v, NULL, NULL, 0, &err); > * if (err) { > - * goto outobj; > + * goto out; > * } > * visit_start_list(v, "list", &err); > * if (err) { > @@ -196,6 +196,7 @@ > * error_propagate(errp, err); > * err = NULL; > * visit_end_struct(v, &err); > + * out: > * error_propagate(errp, err); > * ...clean up v... > * Squashed in and pushed. Thanks!