Received: from eggs.gnu.org ([2001:4830:134:3::10]:39250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJyBl-00049a-KX for qemu-devel@nongnu.org; Tue, 28 Jul 2015 02:16:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJyBk-0001kt-3M for qemu-devel@nongnu.org; Tue, 28 Jul 2015 02:16:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJyBj-0001kk-Ua for qemu-devel@nongnu.org; Tue, 28 Jul 2015 02:16:32 -0400 From: Markus Armbruster References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-27-git-send-email-armbru@redhat.com> <55B00970.2060206@redhat.com> <87mvyhwpjb.fsf@blackfin.pond.sub.org> <55B65B5C.6060600@redhat.com> Date: Tue, 28 Jul 2015 08:16:28 +0200 In-Reply-To: <55B65B5C.6060600@redhat.com> (Eric Blake's message of "Mon, 27 Jul 2015 10:25:00 -0600") Message-ID: <87d1zcq01v.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Eric Blake writes: > On 07/27/2015 10:09 AM, Markus Armbruster wrote: > >> >>> I'm sure there are further things that could be done, but at this point, >>> I hope you get my picture, and I'll quit focusing on this particular patch. >> >> We need to decide how much code churn to accept just for making the diff >> of the generated code easier to review. > > At this point, I'd be happy with just adding a script or other > high-level instructions in the commit message that says how to divide a > generated file into pieces (pull out all *List types into one piece, all > typedefs into another, etc) and which can be done both pre- and > post-patch. With pieces in hand, if you can easily compare that each > pair is minimally different, then you have a nice reassurance that the > difference in the overall file is due merely to differences in how the > pieces are interleaved, and not to added or unintentionally dropped > material. As you pointed out, there comes a point of diminishing > returns in trying to clean up code that will just be discarded. I'll give it a try.