Received: from eggs.gnu.org ([2001:4830:134:3::10]:36521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlXxB-0001mR-B3 for qemu-devel@nongnu.org; Tue, 04 Nov 2014 01:51:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlXx5-0007l4-6b for qemu-devel@nongnu.org; Tue, 04 Nov 2014 01:50:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlXx4-0007l0-VN for qemu-devel@nongnu.org; Tue, 04 Nov 2014 01:50:51 -0500 From: Markus Armbruster References: <1414947218-7618-1-git-send-email-mst@redhat.com> <87bnoouxqn.fsf@blackfin.pond.sub.org> <20141103151955.GA14401@redhat.com> <87egtkuusk.fsf@blackfin.pond.sub.org> <20141103164036.GA31267@redhat.com> Date: Tue, 04 Nov 2014 07:50:46 +0100 In-Reply-To: <20141103164036.GA31267@redhat.com> (Michael S. Tsirkin's message of "Mon, 3 Nov 2014 18:40:36 +0200") Message-ID: <87d293qx15.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , qemu-devel@nongnu.org, peter.maydell@linaro.org "Michael S. Tsirkin" writes: > On Mon, Nov 03, 2014 at 05:13:15PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >> >> "Michael S. Tsirkin" writes: >> >> >> >> > tcp_get_fds API discards fds if there's more than 1 of these. >> >> >> >> s/tcp_get_fds/tcp_get_msgfds/ (subject as well) >> > >> > Right. Too late as I sent this upstream :( >> >> Oh, now I see: you already sent this in a pull request, after less than >> 20 hours on list. Please don't do that except in dire emergency. It >> sabotages our review process. > > I sometimes do this for patches that seem trivial to me. Please don't. No patch is too trivial for review. > I've backed this one out for now. Thanks.