From: Peter Korsgaard Date: Tue, 07 May 2013 17:16:24 +0200 Subject: [U-Boot] [PATCH] tools: default image: use ih_size for checking data size In-Reply-To: <1367581025-26740-1-git-send-email-jogo@openwrt.org> (Jonas Gorski's message of "Fri, 3 May 2013 13:37:05 +0200") References: <1367581025-26740-1-git-send-email-jogo@openwrt.org> Message-ID: <87d2t2252v.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de >>>>> "Jonas" == Jonas Gorski writes: Jonas> Common image usage is uImage + appended rootfs, so the the uImage data Jonas> is only part of the total image. So read out and use the header's Jonas> ih_size field instead of the total file size. Jonas> To prevent reading over the end of the buffer, check that the image file Jonas> is big enough to contain the data before calculating its checksum. Jonas> Before: Jonas> ~# mkimage -l dir665_fw_100NA.bin Jonas> mkimage: ERROR: "dir665_fw_100NA/dir665_fw_100NA.bin" has corrupted data! A related usecase is checking the version info of whatever is written to flash - E.G. mkimage -l /dev/mtdN But that already fails as stat returns st_size=0 for devices. -- Bye, Peter Korsgaard