From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active Date: Thu, 11 Apr 2013 13:08:33 +0200 Message-ID: <87d2u1wci6.fsf@nemi.mork.no> References: <20110727141246.GC29616@orbit.nwl.cc> <1365625850.22411.1.camel@dcbw.foobar.com> <2552222.23e5DWG2Z9@linux-5eaq.site> <87txndwkx1.fsf@nemi.mork.no> <87ppy1wfhq.fsf@nemi.mork.no> <87hajdwefp.fsf@nemi.mork.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Oliver Neukum , Dan Williams , Elina Pasheva , Network Development , linux-usb , Rory Filer , Phil Sutter To: Ming Lei Return-path: Received: from canardo.mork.no ([148.122.252.1]:37495 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780Ab3DKLJL convert rfc822-to-8bit (ORCPT ); Thu, 11 Apr 2013 07:09:11 -0400 In-Reply-To: (Ming Lei's message of "Thu, 11 Apr 2013 18:30:19 +0800") Sender: netdev-owner@vger.kernel.org List-ID: Ming Lei writes: > OK, I say it again, GFP_KERNEL is enough to cover all cases, and the > mem_flags parameter is redundant. The docs for usb_submit_urb() in drivers/usb/core/urb.c lists some possible mem_flags use cases. Among these are (where (b) and (c) are cases needing GFP_ATOMIC and not applicable here): * (3) If you use a kernel thread with a network driver you must use * GFP_NOIO, unless (b) or (c) apply; Is this example=20 a) wrong, or b) not applicable, or=20 c) to be excluded from the new API? Bj=C3=B8rn