Received: from eggs.gnu.org ([208.118.235.92]:57508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIF8A-0008C6-DW for qemu-devel@nongnu.org; Wed, 20 Mar 2013 05:16:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIF85-00045q-Bv for qemu-devel@nongnu.org; Wed, 20 Mar 2013 05:16:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIF85-00045h-4i for qemu-devel@nongnu.org; Wed, 20 Mar 2013 05:16:17 -0400 From: Markus Armbruster References: <5d85837fd58683b7e13ac78d6d468af6e152a512.1363243596.git.hutao@cn.fujitsu.com> Date: Wed, 20 Mar 2013 10:15:59 +0100 In-Reply-To: <5d85837fd58683b7e13ac78d6d468af6e152a512.1363243596.git.hutao@cn.fujitsu.com> (Hu Tao's message of "Thu, 14 Mar 2013 16:15:52 +0800") Message-ID: <87d2uumnxs.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v14 3/4] introduce pvevent device to deal with panicked event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Peter Maydell , Gleb Natapov , "Michael S. Tsirkin" , Jan Kiszka , qemu-devel , Luiz Capitulino , Blue Swirl , Orit Wasserman , Juan Quintela , Alexander Graf , Christian Borntraeger , Andrew Jones , Alex Williamson , Sasha Levin , Stefan Hajnoczi , KAMEZAWA Hiroyuki , Kevin Wolf , Anthony Liguori , Marcelo Tosatti , Paolo Bonzini Hu Tao writes: > pvevent device is used to send guest panic event from guest to qemu. > > When guest panic happens, pvevent device driver will write a event > number to IO port 0x505(which is the IO port occupied by pvevent device, > by default). On receiving the event, pvevent device will pause guest > cpu(s), and send a qmp event QEVENT_GUEST_PANICKED. > > TODO: make the IO port configurable > > Signed-off-by: Wen Congyang > Signed-off-by: Hu Tao > --- > hw/Makefile.objs | 2 + > hw/pvevent.c | 116 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 118 insertions(+) > create mode 100644 hw/pvevent.c > > diff --git a/hw/Makefile.objs b/hw/Makefile.objs > index 40ebe46..edf499e 100644 > --- a/hw/Makefile.objs > +++ b/hw/Makefile.objs > @@ -218,5 +218,7 @@ obj-$(CONFIG_KVM) += ivshmem.o > obj-$(CONFIG_LINUX) += vfio_pci.o > endif > > +common-obj-y += pvevent.o > + > $(obj)/baum.o: QEMU_CFLAGS += $(SDL_CFLAGS) > endif > diff --git a/hw/pvevent.c b/hw/pvevent.c > new file mode 100644 > index 0000000..c7df77b > --- /dev/null > +++ b/hw/pvevent.c > @@ -0,0 +1,116 @@ > +/* > + * QEMU simulated pvevent device. > + * > + * Copyright Fujitsu, Corp. 2013 > + * > + * Authors: > + * Wen Congyang > + * Hu Tao > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +/* The bit of supported pv event */ > +#define PVEVENT_F_PANICKED 0 > + > +/* The pv event value */ > +#define PVEVENT_PANICKED (1 << PVEVENT_F_PANICKED) This looks like events are encoded as bits, which can be combined into a set, but... > + > +#define TYPE_ISA_PVEVENT_DEVICE "pvevent" > +#define ISA_PVEVENT_DEVICE(obj) \ > + OBJECT_CHECK(PVEventState, (obj), TYPE_ISA_PVEVENT_DEVICE) > + > +static void panicked_mon_event(const char *action) > +{ > + QObject *data; > + > + data = qobject_from_jsonf("{ 'action': %s }", action); > + monitor_protocol_event(QEVENT_GUEST_PANICKED, data); > + qobject_decref(data); > +} > + > +static void handle_event(int event) > +{ > + if (event == PVEVENT_PANICKED) { ... here you don't test bits. Weird. Intentional? > + panicked_mon_event("pause"); > + vm_stop(RUN_STATE_GUEST_PANICKED); > + return; > + } > +} Should we log events we don't understand? > + > +#include "hw/isa.h" > + > +typedef struct PVEventState { > + ISADevice parent_obj; > + > + MemoryRegion io; > + uint16_t ioport; > +} PVEventState; > + > +/* return supported events on read */ > +static uint64_t pvevent_ioport_read(void *opaque, hwaddr addr, unsigned size) > +{ > + return PVEVENT_PANICKED; > +} > + > +static void pvevent_ioport_write(void *opaque, hwaddr addr, uint64_t val, > + unsigned size) > +{ > + handle_event(val); > +} [...]