From: Eric Anholt Subject: Re: [PATCH] drm/i915: Set two chicken bits implicated in missed IRQs on Ivybridge. Date: Thu, 22 Dec 2011 09:39:12 -0800 Message-ID: <87d3bgh5fj.fsf@eliezer.anholt.net> References: <1324492269-3377-1-git-send-email-eric@anholt.net> <4EF24F04.5040905@bwidawsk.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0757878398==" Return-path: In-Reply-To: <4EF24F04.5040905@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0757878398== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 21 Dec 2011 13:26:28 -0800, Ben Widawsky wrote: > On 12/21/2011 10:31 AM, Eric Anholt wrote: > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i91= 5/intel_display.c > > index 8a61b81..1fe0c67 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -8252,6 +8252,10 @@ static void ivybridge_init_clock_gating(struct d= rm_device *dev) > >=20=20 > > I915_WRITE(ILK_DSPCLK_GATE, IVB_VRHUNIT_CLK_GATE); > >=20=20 > > + I915_WRITE(IVB_CHICKEN3, > > + CHICKEN3_DGMG_REQ_OUT_FIX_DISABLE | > > + CHICKEN3_DGMG_DONE_FIX_DISABLE); > > + > > for_each_pipe(pipe) { > > I915_WRITE(DSPCNTR(pipe), > > I915_READ(DSPCNTR(pipe)) | >=20 > Fwiw, CHICKEN3_DGMG_DONE_FIX_DISABLE also applies to SNB, but we're > waiting on feedback if we should set it. It may be better to set both > platforms at once (ie. hold off on this patch)? If it's different code in a different place for a different platform, it should definitely be a different patch. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk7za0AACgkQHUdvYGzw6vfbIQCfWlyG3Cm5kcWczg/oAZ2dWn38 kEMAmwVOs341GzQ//Sh8ucWYXOjUSHXx =SNQQ -----END PGP SIGNATURE----- --=-=-=-- --===============0757878398== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0757878398==--