From: OGAWA Hirofumi Subject: Re: [PATCH v6] fat: Batched discard support for fat Date: Tue, 29 Mar 2011 15:37:17 +0900 Message-ID: <87d3la4ele.fsf@devron.myhome.or.jp> References: <20110328103431.GA22323@july> <87k4fi4iwq.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Lukas Czerner To: Kyungmin Park Return-path: In-Reply-To: (Kyungmin Park's message of "Tue, 29 Mar 2011 14:11:35 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Kyungmin Park writes: >> Again, this ioctl's design is unclear, and seems to be strange. I >> wouldn't want to add this before clearing it. Please explain what is >> right behavior. > > Umm it's out of my scope. it's trim design. > See also btrfs batched discard support. it's also no consideration as > you mentioned. > > As I know, now xfs, ext4, and btrfs support this fstrim without these concern. > > http://thread.gmane.org/gmane.comp.file-systems.btrfs/9758 I looked at fstrim.c. It is lowlevel tools to just issue FITRIM - it doesn't use the result at all. Um. Honestly I'd like to see more or wait until real user for now, instead of providing unclear design. Thanks. -- OGAWA Hirofumi