Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80F13C433EF for ; Wed, 22 Jun 2022 08:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aSujP9Ioa2EJMSJGftMxZVBM+RmhPi7tdWCBaYi34Yc=; b=YBixZaPdW7EN+k tO05mqFslgw8ZXfbVNxKcQPg01SJQhbDcLW5x8BPjakzK2tsPUK6rOwhBuMaNdYudlBzKDDebGOMQ CDzX6UN2gAdAEMPAlmQiVVXGgI50HpEIoYso2+86/VMTbq/yAG3rppTmn8oPmnrFcmZUCRP2Y3P9g nfyJDctDYjzkm2HSE7slzTwt1r2aH/4UTlgL/Hio4SeRcQ8m2PVzb2+eM6FSqzJ7GHGSC20Be588B STfN8FhhWCpyPYCBjqqtkmM03Pibp+Ne/4nd5aBmNcRhHWsqtVDLfQQJCv963lGuiW0mTBc2X4Ekf 2zC9zWlhoU72tOW1mhzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3wCS-009P5y-Mm; Wed, 22 Jun 2022 08:59:00 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3wCP-009P4z-TT for linux-arm-kernel@lists.infradead.org; Wed, 22 Jun 2022 08:58:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 51E8FB81CBF; Wed, 22 Jun 2022 08:58:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81E80C34114; Wed, 22 Jun 2022 08:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655888335; bh=zEDBJcc/hdKUEzKTw+o0NSo3+GElIveIOWIAX5Umga4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RrOb+Oxnpuv9oTXXSKoSc2qCWY6eMt1SluoCJ0PZeE7QYfgEU2rEa7S4qR/bcrj/F DEC9M71KfVDqPI5SdJz5XYYofnAdYzTYv6hdqfoZhFDwWYDTx7pQFc0K2x25CQQTUc Cwj2+DuZs5SQ+MwhHnvw4heHFkRQmwLt/W/g0oNXnfrd8qrnR5sUi/ZAdlseeuc7X4 ZhYrJeoAFUchAe21OHc0+X550LALA7nHwnfWZeZ73pqMAatUueVAs/Qc+5uG5bqkgY PFQtLHW/m2+E0EOap+NJAFfrWVIVtIIjQjAZ5gosTA1WJBQvtwmvFXiFRCTmCQ7+4E 3Txko6QX5gOoA== Message-ID: <87dd706a-6777-374f-1d41-7d791727697f@kernel.org> Date: Wed, 22 Jun 2022 10:58:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3] arm/mm: Fix refcount leak bugs in cache Content-Language: en-US To: Liang He , linux@armlinux.org.uk, rmk+kernel@armlinux.org.uk, wangkefeng.wang@huawei.com, ardb@kernel.org, arnd@arndb.de, akpm@linux-foundation.org, rppt@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220619013941.4061894-1-windhl@126.com> From: Krzysztof Kozlowski In-Reply-To: <20220619013941.4061894-1-windhl@126.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_015858_171454_74D4315F X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/06/2022 03:39, Liang He wrote: > In feroceon_of_init() and tauros2_init(), of_find_matching_node() > will return a node pointer with refcount incremented. We should > use of_node_put() in fail path or when it is not used anymore. > > Signed-off-by: Liang He > --- > changelog: > > v3: (1) merge arm/mm leak bugs (2) fix bugs intro-ed by v2 > v2: (1) use real name (2) normalize coding style > v1: (1) fix leak bug > Before applying the patch please check it carefully. Previous evidence [1][2] suggests that not it was not even compiled. [1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/ [2] https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel