From: "plaisthos (Code Review)" Date: Tue, 12 Dec 2023 18:24:05 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <87e0dbb847c3af5b3ea7a9a861b788c68e2ac61b-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="2KaM+oVh0xc="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , cron2 , openvpn-devel --2KaM+oVh0xc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/466?usp=3Demail ) Change subject: Implement the --tls-export-cert feature ...................................................................... Patch Set 4: (2 comments) File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/466/comment/f51f4a78_549de142 : PS4, Line 427: Adds an environment variables ``peer_cert_{x}`` (and an al= ias > "variable" or remove "an" Done http://gerrit.openvpn.net/c/openvpn/+/466/comment/eed49c31_f5661e3b : PS4, Line 780: :code:`peer_cert` identical to `peer_cert_0` for compatibili= ty with older > Missing line break before "identical". [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2 Gerrit-Change-Number: 466 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 12 Dec 2023 18:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --2KaM+oVh0xc= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld.

View C= hange

2 comments:

    =
  • File doc/man-sections/script-option= s.rst:

    • Patch Set #4= , Line 427: Adds an e= nvironment variables ``peer_cert_{x}`` (and an alias

      = "variable" or remove "an"

      Done

    • Patch S= et #4, Line 780: :code:= `peer_cert` identical to `peer_cert_0` for compatibility with older<= /p>

      Missing line break before "identical". [=E2=80=A6]=

      Done

To view, visit change 466. To unsubscribe, or fo= r help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b= 4cebd0bf19ce2
Gerrit-Change-Number: 466
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 12 Dec 2023 18:24:05= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--2KaM+oVh0xc=--