Received: from eggs.gnu.org ([2001:4830:134:3::10]:55777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cg6Pp-000113-0B for qemu-devel@nongnu.org; Tue, 21 Feb 2017 04:07:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cg6Pk-0005da-4E for qemu-devel@nongnu.org; Tue, 21 Feb 2017 04:07:21 -0500 From: Markus Armbruster References: <20170220164509.27868-1-v.maffione@gmail.com> Date: Tue, 21 Feb 2017 10:07:13 +0100 In-Reply-To: <20170220164509.27868-1-v.maffione@gmail.com> (Vincenzo Maffione's message of "Mon, 20 Feb 2017 17:45:09 +0100") Message-ID: <87efyrnc8u.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincenzo Maffione Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, pbonzini@redhat.com Vincenzo Maffione writes: > In the vhost-user example, a chardev with id chr0 is referenced by the > vhost-user net backend, but the id is not specified in the chardev option. > > Signed-off-by: Vincenzo Maffione > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 5633d3914f..ed22fc479a 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2127,7 +2127,7 @@ Example: > @example > qemu -m 512 -object memory-backend-file,id=mem,size=512M,mem-path=/hugetlbfs,share=on \ > -numa node,memdev=mem \ > - -chardev socket,path=/path/to/socket \ > + -chardev socket,id=chr0,path=/path/to/socket \ > -netdev type=vhost-user,id=net0,chardev=chr0 \ > -device virtio-net-pci,netdev=net0 > @end example Reviewed-by: Markus Armbruster Aside: a test that extracts its test cases out of qemu-options.hx and verifies they at least don't make startup fail would be nice. Bit-sized task only if you have a really big jaw, I'm afraid.