From: Eric Anholt Subject: Re: [PATCH 2/3] drm/vc4: Enable runtime PM. Date: Tue, 16 Feb 2016 10:53:27 -0800 Message-ID: <87egccsd08.fsf@eliezer.anholt.net> References: <1454977179-16913-1-git-send-email-eric@anholt.net> <1454977179-16913-3-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1598269953==" Return-path: In-Reply-To: <1454977179-16913-3-git-send-email-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org --===============1598269953== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Eric Anholt writes: > +#ifdef CONFIG_PM_SLEEP > +static int vc4_v3d_runtime_suspend(struct device *dev) > +{ > + struct vc4_v3d *v3d = dev_get_drvdata(dev); > + struct vc4_dev *vc4 = v3d->vc4; > + > + vc4_irq_uninstall(vc4->dev); > + > + return 0; > +} > + > +static int vc4_v3d_runtime_resume(struct device *dev) > +{ > + struct vc4_v3d *v3d = dev_get_drvdata(dev); > + struct vc4_dev *vc4 = v3d->vc4; > + > + vc4_v3d_init_hw(vc4->dev); > + vc4_irq_postinstall(vc4->dev); > + > + return 0; > +} > +#endif kbuild test robot caught that this #ifdef should have been CONFIG_PM, not CONFIG_PM_SLEEP. Fixed in v2. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWw3AoAAoJELXWKTbR/J7ofvYQAKXF3IBevAnh4rdGcyRmReAU I3/4/9gxReD8ze8L8SDmD8DmDPHEywlQyZUz6Gz/IlmXx80yew69kz7EaDwRh1ME T37kSDVkePokMdB0sZQ2fT5XMkG5Ba/Ba/N1eyyO3EmqsQjigLPBMKHIZtxtyNto 6vCOG0iydYBDJUSuUXidWiZR1IkMUpBxeXXpTMHpJgvpSdBJG/Vw/4D1pzOewMv5 DNnazVtgQjA3QERVmYN4c017kc5/iKtbbBbFiAOJ83bYjoEkrsBcxNZ91WdomyT/ 5GAO8YgXnYuFOL2AYCASOrBZrfjjHSWUy3n3do04gKXpsWwpB2jrA6vxGfYmgVXT 9+AokzzdWPz9W71BO6BVYPN2CTH6CNcJDfLG1OROnWWw6em9lz0QMK+rFgsztgYv J2+DPE38H+6PSWINc19DbJ+WI3tN28EAueQrbGi+cHMnPUDakWs5D4MqPthFgjJF eA67MUlVFN12xCfueyzJcIjhV/ajd0Be1XH1V87MZ4LTMH66wAX7Bl/6UDR0Tb5o z7P+POXoqcmIn5nPCSn5Jmh01JP4mnhmGqkhLekF9dl9krCm7k//5Zc2Mnhvni40 2SwkUcA+fvZXPjYEnwavga50QBTA4GIJoH+tSNhJPgPawzmnpmNGqzI+SM7vFt8b AdjEu4WhU441hesYdOA8 =lArq -----END PGP SIGNATURE----- --=-=-=-- --===============1598269953== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1598269953==--