From: khilman@ti.com (Kevin Hilman) Date: Tue, 31 Jan 2012 09:44:10 -0800 Subject: [PATCH] ARM: OMAP3+: PM debug: fix the use of debugfs_create_* API In-Reply-To: <1328008819-1110-1-git-send-email-j-pihet@ti.com> (Jean Pihet's message of "Tue, 31 Jan 2012 12:20:19 +0100") References: <1328008819-1110-1-git-send-email-j-pihet@ti.com> Message-ID: <87ehufojh1.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Jean Pihet writes: > The debugfs_create_* API returns a NULL ptr in case of problem. > Fix the PM debug code to take this into account. > > Signed-off-by: Jean Pihet > --- > arch/arm/mach-omap2/pm-debug.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c > index 4411163..e5bf367 100644 > --- a/arch/arm/mach-omap2/pm-debug.c > +++ b/arch/arm/mach-omap2/pm-debug.c > @@ -264,8 +264,8 @@ static int __init pm_dbg_init(void) > return 0; > > d = debugfs_create_dir("pm_debug", NULL); > - if (IS_ERR(d)) > - return PTR_ERR(d); > + if (!d) I think this should be IS_ERR_OR_NULL() because this function can also return ERR_PTR(-ENODEV). (Yes, only when debugfs is not enabled, but it's still more correct.) Kevin > + return -ENOMEM; > (void) debugfs_create_file("count", S_IRUGO, > d, (void *)DEBUG_FILE_COUNTERS, &debug_fops);