From: Eric Anholt Subject: Re: [PATCH] convert intel_ring_begin count to dword Date: Mon, 14 Jun 2010 18:29:29 -0700 Message-ID: <87eig9ytfq.fsf@pollan.anholt.net> References: <1276335624-6404-1-git-send-email-nanhai.zou@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1914976364==" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 222409E7BF for ; Mon, 14 Jun 2010 13:55:59 -0700 (PDT) In-Reply-To: <1276335624-6404-1-git-send-email-nanhai.zou@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zou Nan hai , intel-gfx List-Id: intel-gfx@lists.freedesktop.org --===============1914976364== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 12 Jun 2010 17:40:24 +0800, Zou Nan hai wrot= e: > convert intel_ring_begin count to dword, > fix some wrong intel_ring_begin size. Please don't repeat the first line of the commit message twice, but please do prepend "drm/i915: " for patches to the DRM. When I applied your patch, I got: commit 186c799be39c5bbc845fe2eccdb87d0ad315e521 Author: Zou Nan hai Date: Sat Jun 12 17:40:24 2010 +0800 convert intel_ring_begin count to dword =20=20=20=20 convert intel_ring_begin count to dword, fix some wrong intel_ring_begin size. =20=20=20=20 Signed-off-by: Zou Nan hai Signed-off-by: Eric Anholt I rewrote it to be: commit be26a10bd10271b4a810ece2e540c0cdd77881bc Author: Zou Nan hai Date: Sat Jun 12 17:40:24 2010 +0800 drm/i915: Fix incorrect intel_ring_begin size in BSD ringbuffer. =20=20=20=20 The ring_begin API was taking a number of bytes, while all of our other begin/end macros take number of dwords. Change the API over to dwords to prevent future bugs. =20=20=20=20 Signed-off-by: Zou Nan hai Signed-off-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkwW13kACgkQHUdvYGzw6vfTqQCgj9EukVEseNuM2RAivnFIBi/B mDUAniSVzXU+sqqR1F69gYcVxcsgpFQD =LiLV -----END PGP SIGNATURE----- --=-=-=-- --===============1914976364== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1914976364==--