Received: from eggs.gnu.org ([2001:4830:134:3::10]:60529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgbvm-00047i-Ir for qemu-devel@nongnu.org; Wed, 22 Feb 2017 13:46:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgbvj-0000H5-Gg for qemu-devel@nongnu.org; Wed, 22 Feb 2017 13:46:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30424) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgbvj-0000Gv-Ac for qemu-devel@nongnu.org; Wed, 22 Feb 2017 13:46:23 -0500 From: Markus Armbruster References: <1487709988-14322-1-git-send-email-armbru@redhat.com> <1487709988-14322-4-git-send-email-armbru@redhat.com> Date: Wed, 22 Feb 2017 19:46:20 +0100 In-Reply-To: (Eric Blake's message of "Wed, 22 Feb 2017 09:14:32 -0600") Message-ID: <87fuj6ukqr.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 3/3] i386/cpu: net: Flatten simple union GuestPanicInformationType List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, "Denis V . Lunev" , Anton Nefedov , Paolo Bonzini Eric Blake writes: > On 02/21/2017 02:46 PM, Markus Armbruster wrote: >> Simple unions are simpler than flat unions in the schema, but more >> complicated in C and on the QMP wire: there's extra indirection in C >> and extra nesting on the wire, both pointless. They're best avoided >> in new code. Fix up recent commit d187e08 accordingly. >> >> Cc: Anton Nefedov >> Cc: Denis V. Lunev >> Signed-off-by: Markus Armbruster >> --- >> qapi-schema.json | 14 ++++++++++++-- >> target/i386/cpu.c | 17 ++++++----------- >> vl.c | 12 ++++++------ >> 3 files changed, 24 insertions(+), 19 deletions(-) > > Very similar to Anton's patch which is on Paolo's queue: > https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg04448.html Wasn't cc'ed, so I missed it. No biggie. > I don't care which version goes in, but will leave it to Markus and > Paolo to decide which queue it should go through. My commit message is more verbose, and I fix space style in the QAPI schema. On the other hand, Anton has an extra QAPI schema comment line. Picking Anton's is probably simpler, because it's 2/3, and mine looks like it conflicts with his 1/3. > Reviewed-by: Eric Blake Thanks!