Received: from eggs.gnu.org ([2001:4830:134:3::10]:36843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwZKq-0004VF-My for qemu-devel@nongnu.org; Wed, 11 Nov 2015 12:38:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwZJT-0005zh-Ky for qemu-devel@nongnu.org; Wed, 11 Nov 2015 12:37:28 -0500 From: Markus Armbruster References: <1447224690-9743-1-git-send-email-eblake@redhat.com> <1447224690-9743-19-git-send-email-eblake@redhat.com> <87si4cboqt.fsf@blackfin.pond.sub.org> <56436A90.3010301@redhat.com> Date: Wed, 11 Nov 2015 18:31:39 +0100 In-Reply-To: <56436A90.3010301@redhat.com> (Eric Blake's message of "Wed, 11 Nov 2015 09:19:28 -0700") Message-ID: <87fv0c5tok.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Jiri Pirko , Eduardo Habkost , "open list:Block layer core" , "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Scott Feldman , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= , Richard Henderson Eric Blake writes: > On 11/11/2015 07:21 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in >>> since c6bd8c706. Nuke them. >> >> Doesn't really belong to this series, but that's okay. > > If you're going to modify this for 2.5 inclusion through your qerror > tree, you may want to change the description to: I'll try to get this into 2.5 mostly for the documentation update. > A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) were missed in > c6bd8c706, or have snuck in since. Nuke them. Done. >>> +++ b/hw/i386/pc.c >>> @@ -1795,7 +1795,7 @@ static void pc_machine_set_max_ram_below_4g(Object *obj, Visitor *v, >>> return; >>> } >>> if (value > (1ULL << 32)) { >>> - error_set(&error, ERROR_CLASS_GENERIC_ERROR, >>> + error_setg(&error, >>> "Machine option 'max-ram-below-4g=%"PRIu64 >>> "' expects size less than or equal to 4G", value); >> >> Indentation is now off. Can tidy up in my tree. >> >>> error_propagate(errp, error); >> [Rest snipped, it looks good] >> > > There's also the question if we want to address the ErrorClass name > munging of 19/28 by adding your idea of an aliasing typedef in error.h; > if so, should I prepare a smaller patch series of both of those changes > for consideration for 2.5? Can safely wait for 2.6, can't it?