Received: from eggs.gnu.org ([2001:4830:134:3::10]:44575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zttzd-0007pc-GW for qemu-devel@nongnu.org; Wed, 04 Nov 2015 04:04:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZttzY-0004cd-AQ for qemu-devel@nongnu.org; Wed, 04 Nov 2015 04:04:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZttzY-0004cP-48 for qemu-devel@nongnu.org; Wed, 04 Nov 2015 04:04:28 -0500 From: Markus Armbruster References: <1446618049-13596-1-git-send-email-eblake@redhat.com> <1446618049-13596-6-git-send-email-eblake@redhat.com> Date: Wed, 04 Nov 2015 10:04:24 +0100 In-Reply-To: <1446618049-13596-6-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 3 Nov 2015 23:20:27 -0700") Message-ID: <87fv0mt9t3.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v9 05/27] qapi: More tests of alternate output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth Suggest "qapi: Test alternate output visitor with boxed type" Eric Blake writes: > The testsuite was only covering that we could output a built-in > branch of an alternate; make sure that things still work even Well, 'str' is built-in, too. "'int' branch"? > when a branch involves allocation, to ensure that we don't leak > when run under valgrind. More pedantry: we'd leak when not running under valgrind just as much. > Update to modern style of g_new0() over g_malloc0() while > touching it. > > Signed-off-by: Eric Blake Patch looks good.