Received: from eggs.gnu.org ([208.118.235.92]:54327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG72l-00043v-RW for qemu-devel@nongnu.org; Thu, 14 Mar 2013 08:14:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UG72k-0007k1-Fi for qemu-devel@nongnu.org; Thu, 14 Mar 2013 08:13:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UG72k-0007ix-8O for qemu-devel@nongnu.org; Thu, 14 Mar 2013 08:13:58 -0400 From: Markus Armbruster References: <60194bbd0a9d9259beb9a14e19c1706bd9a07e97.1363196545.git.mst@redhat.com> <878v5q2yo8.fsf@blackfin.pond.sub.org> <20130314084817.GA14977@redhat.com> Date: Thu, 14 Mar 2013 13:13:54 +0100 In-Reply-To: <20130314084817.GA14977@redhat.com> (Michael S. Tsirkin's message of "Thu, 14 Mar 2013 10:48:17 +0200") Message-ID: <87fvzyw54t.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Kevin Wolf , Anthony Liguori , Eduardo Habkost , libvir-list@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Luiz Capitulino , Gerd Hoffmann , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= "Michael S. Tsirkin" writes: > On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: [...] >> > diff --git a/qapi-schema.json b/qapi-schema.json >> > index 28b070f..bb361e1 100644 >> > --- a/qapi-schema.json >> > +++ b/qapi-schema.json >> > @@ -2354,7 +2354,9 @@ >> > # Notes: When this command completes, the device may not be removed from the >> > # guest. Hot removal is an operation that requires guest cooperation. >> > # This command merely requests that the guest begin the hot removal >> > -# process. >> > +# process. Completion of the device removal process is signaled with a >> > +# DEVICE_DELETED event. Guest reset will automatically complete removal >> > +# for all devices. >> > # >> > # Since: 0.14.0 >> > ## >> >> What do you mean by "Guest reset will automatically complete removal for >> all devices"? > > Just this. Try this: rmmod acpiphp in guest, then: > > device_del > system_reset > > and see the device disappear even though it was not acked by guest. Cool, I didn't know that. Just to make sure: does this automatic removal completion send DEVICE_DELETED events?