From: OGAWA Hirofumi Subject: Re: [PATCH v6 4/7] fat: restructure export_operations Date: Mon, 18 Feb 2013 20:06:31 +0900 Message-ID: <87fw0t3mq0.fsf@devron.myhome.or.jp> References: <1360422145-12280-1-git-send-email-linkinjeon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Ravishankar N , Amit Sahrawat To: Namjae Jeon Return-path: In-Reply-To: <1360422145-12280-1-git-send-email-linkinjeon@gmail.com> (Namjae Jeon's message of "Sun, 10 Feb 2013 00:02:25 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Namjae Jeon writes: > + if (MSDOS_SB(inode->i_sb)->options.nfs == FAT_NFS_NOSTALE_RO) { > + if (inode->i_ino == MSDOS_ROOT_INO) > + stat->ino = MSDOS_ROOT_INO; Can we simply set i_pos = MSDOS_ROOT_INO in fat_read_root()? If so, I think we can avoid this check. > + else > + /* Use i_pos for ino. This is used as fileid of nfs. */ > + stat->ino = fat_i_pos_read(MSDOS_SB(inode->i_sb), > + inode); > + } > return 0; > } > EXPORT_SYMBOL_GPL(fat_getattr); > +struct fat_fid { > + u32 i_gen; > + u32 i_pos_low; > + u16 i_pos_hi; > + u16 parent_i_pos_hi; > + u32 parent_i_pos_low; > + u32 parent_i_gen; > +} __packed; Do we need to use __packed? Unnecessary __packed can generate slower code for alignment check on arch has unaligned fault. > + if (parent && (len < FAT_FID_SIZE_WITH_PARENT)) { > + *lenp = FAT_FID_SIZE_WITH_PARENT; > + return 255; > + } else if (len < FAT_FID_SIZE_WITHOUT_PARENT) { > + *lenp = FAT_FID_SIZE_WITHOUT_PARENT; > + return 255; > + } This check strange. "parent && len == FAT_FID_SIZE_WITHOUT_PARENT" will overwrite over limit of fh size? -- OGAWA Hirofumi